[lld] r325650 - [lit] Fix a problem with spaces in the python path by adding quotes around it

Aaron Smith via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 16:03:42 PST 2018


Author: asmith
Date: Tue Feb 20 16:03:41 2018
New Revision: 325650

URL: http://llvm.org/viewvc/llvm-project?rev=325650&view=rev
Log:
[lit] Fix a problem with spaces in the python path by adding quotes around it

Summary:
This fixes two failing tests on Windows with an installed version of python that has spaces in the path.

* elf/lto/cache.ll
* mach-o/dependency_info.yaml

Reviewers: zturner, llvm-commits, stella.stamenova

Subscribers: emaste, arichardson

Differential Revision: https://reviews.llvm.org/D43265

Modified:
    lld/trunk/test/ELF/lto/cache.ll
    lld/trunk/test/mach-o/dependency_info.yaml

Modified: lld/trunk/test/ELF/lto/cache.ll
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/cache.ll?rev=325650&r1=325649&r2=325650&view=diff
==============================================================================
--- lld/trunk/test/ELF/lto/cache.ll (original)
+++ lld/trunk/test/ELF/lto/cache.ll Tue Feb 20 16:03:41 2018
@@ -13,7 +13,7 @@
 ; RUN: ls %t.cache | count 4
 
 ; Create a file of size 64KB.
-; RUN: %python -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
+; RUN: "%python" -c "print(' ' * 65536)" > %t.cache/llvmcache-foo
 
 ; This should leave the file in place.
 ; RUN: ld.lld --thinlto-cache-dir=%t.cache --thinlto-cache-policy cache_size_bytes=128k:prune_interval=0s -o %t3 %t2.o %t.o

Modified: lld/trunk/test/mach-o/dependency_info.yaml
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/mach-o/dependency_info.yaml?rev=325650&r1=325649&r2=325650&view=diff
==============================================================================
--- lld/trunk/test/mach-o/dependency_info.yaml (original)
+++ lld/trunk/test/mach-o/dependency_info.yaml Tue Feb 20 16:03:41 2018
@@ -9,7 +9,7 @@
 # RUN:        -F/Custom/Frameworks \
 # RUN:        -framework Bar \
 # RUN:        -framework Foo
-# RUN: %python %p/Inputs/DependencyDump.py %t.info | FileCheck %s
+# RUN: '%python' %p/Inputs/DependencyDump.py %t.info | FileCheck %s
 
 
 # CHECK: linker-vers: lld




More information about the llvm-commits mailing list