[PATCH] D43324: WIP: [Utils] Salvage debug info of DCE'ed extractvalue instructions

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:1625
+      } else {
+        llvm_unreachable("Not a valid type to index into with extractvalue");
+      }
----------------
Maybe this could/should be:

  if (auto *StructTy = dyn_cast<StructType(IndexedTy)) {
    ...
  } else {
    assert(array type);
    ...
  }


https://reviews.llvm.org/D43324