[PATCH] D43436: [Perf] Simplify llvm::StringSwitch and improve incremental rebuild by 54%
Jordan Rose via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 20 10:35:48 PST 2018
jordan_rose added inline comments.
================
Comment at: include/llvm/ADT/StringRef.h:875
+
+ // HACK -- The Google unit tests need/want strings like "foo\0bar" to work.
+ template <size_t N>
----------------
I don't think this should be marked a hack. Sometimes people want to make StringRefs containing nul bytes. It's reasonable that it's explicit now, though.
Repository:
rL LLVM
https://reviews.llvm.org/D43436
More information about the llvm-commits
mailing list