[PATCH] D43332: [AMDGPU] stop buffer_store being moved illegally

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM except test cleanups



================
Comment at: test/CodeGen/AMDGPU/buffer-schedule.ll:4-5
+
+target datalayout = "e-p:64:64-p1:64:64-p2:64:64-p3:32:32-p4:32:32-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-A5"
+target triple = "amdgcn--amdpal"
+
----------------
Remove these and specify the full triple to the llc run line


================
Comment at: test/CodeGen/AMDGPU/buffer-schedule.ll:20-21
+
+target datalayout = "e-p:64:64-p1:64:64-p2:64:64-p3:32:32-p4:32:32-p5:32:32-p6:32:32-i64:64-v16:16-v24:32-v32:32-v48:64-v96:128-v192:256-v256:256-v512:512-v1024:1024-v2048:2048-n32:64-A5"
+target triple = "amdgcn--amdpal"
+
----------------
Extra copies


================
Comment at: test/CodeGen/AMDGPU/buffer-schedule.ll:23
+
+; Function Attrs: nounwind
+define amdgpu_cs void @_amdgpu_cs_main(<3 x i32> inreg %arg3, <3 x i32> %arg5) {
----------------
Delete attribute comments


Repository:
  rL LLVM

https://reviews.llvm.org/D43332