[PATCH] D43168: Don't use -ldl on BSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 21:48:01 PST 2018


krytarowski added a comment.

In https://reviews.llvm.org/D43168#1012853, @krytarowski wrote:

> If I read the CMake's source code correctly, just including `find_package(Threads)` is enough to set OS specific flags.
>
> https://github.com/Kitware/CMake/blob/9a509099f77ed32a0845e4e3fad7b8f1eb9be10b/Modules/FindThreads.cmake


Or perhaps not. I agree that it's better to go for `-pthread` for now, at least for consistency with existing code.


Repository:
  rL LLVM

https://reviews.llvm.org/D43168





More information about the llvm-commits mailing list