[PATCH] D43168: Don't use -ldl on BSD
Matthias Braun via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 19 21:37:46 PST 2018
MatzeB added a comment.
In https://reviews.llvm.org/D43168#1012849, @krytarowski wrote:
> `-pthreads` defines additional OS specific flags like `_REENTRANT` or `_PTHREADS` and this is the form that should be used.
+1 for using `-pthread` which should do the right thing for platforms supported by clang/gcc.
> Regarding refactoring CMake's usage, I'm not sure it's worth the churn to move things around unless we address real bugs.
Well the rest of the test-suite currently uses `-pthread` while this switches to `find_package(Threads) list(APPEND LDFLAGS ${CMAKE_THREAD_LIBS_INIT})` making things inconsistent with the rest (without addressing real bugs either :)
Repository:
rL LLVM
https://reviews.llvm.org/D43168
More information about the llvm-commits
mailing list