[PATCH] D43484: Inline applyRelocations into writeTo.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 16:31:38 PST 2018


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

This doesn't seem strictly better to me.  Seems like it only increases the complexity and the indentations of the code, and while decreasing re-usability.  Is there a specific benefit?   Shouldn't we prefer shorter and less nested functions?


https://reviews.llvm.org/D43484





More information about the llvm-commits mailing list