[PATCH] D43165: [lit] Fix problem in how Python versions open files with different encodings
Aaron Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 19 11:57:10 PST 2018
asmith added a comment.
Hi MatzeB,
We don't have any other ideas for how to fix this and I'm wondering if you are okay with committing this so that the lldb unit tests will pass on Windows (with a few more changes)?
I can commit this change, or I can commit a different change that catches the exception when open fails and reopens in 'Latin-1', or we can try something else like marking the tests as XFAIL on Windows and letting the original authors fix them.
Aaron
Repository:
rL LLVM
https://reviews.llvm.org/D43165
More information about the llvm-commits
mailing list