[PATCH] D43253: bitcode support change for fast flags compatibility

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

In https://reviews.llvm.org/D43253#1011978, @hans wrote:

> In https://reviews.llvm.org/D43253#1010580, @mehdi_amini wrote:
>
> > In https://reviews.llvm.org/D43253#1010451, @qcolombet wrote:
> >
> > > Thanks all for the great feedbacks!
> > >
> > > The final solution is much better than a dumb bump of the bitcode version.
> > >
> > > LGTM.
> >
> >
> > Note: we need buy-in from LLVM 6.0 release manager (@hans ?) that this will be cherry-picked there before landing this in trunk.
>
>
> This seems fine for 6.0 (it needs to land soon though), but why does it need to be cherry-picked to the branch before landing on trunk?


Sorry for the ambiguity, I meant that we needed your confirmation before landing this in trunk, not that the cherry-pick has to happen before.
i.e. parenthesis were intended like this "we need (buy-in from LLVM 6.0 release manager that this will be cherry-picked there) before landing this in trunk."

Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D43253