[PATCH] D43146: [builtins] Fix c?zdi2 on sparc64/Linux and refine mips64/riscv tests

James Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 11:30:53 PST 2018


jrtc27 added a comment.

In https://reviews.llvm.org/D43146#1012323, @joerg wrote:

> We tried to keep the condition simple. I.e. does the compiler on any of those platforms ever use the libcall? If not, it is IMO not worth the complexity.


Ok, I can see the argument for getting rid of the mips64 complexity, but I'd say the `__SIZEOF_POINTER__` check should stay for riscv, since it definitely won't be a problem for riscv32. Would you agree with that?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43146





More information about the llvm-commits mailing list