[PATCH] D41813: [builtins] Enable CRT_HAS_128BIT for MSVC
Joerg Sonnenberger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 19 09:14:32 PST 2018
joerg requested changes to this revision.
joerg added inline comments.
This revision now requires changes to proceed.
================
Comment at: lib/builtins/muloti4.c:56
{
- if (abs_a > MIN / -abs_b)
+ if (abs_a > __divti3(MIN, -abs_b))
*overflow = 1;
----------------
I find this and related changes to be not acceptable. It hard-codes the assumption that the division is not lowered natively by the compiler, which is IMO not valid.
https://reviews.llvm.org/D41813
More information about the llvm-commits
mailing list