[PATCH] D43458: "Fix CMake/MSVC when compiler-rt and llvm are built separately"

[Loo Rong Jie via Phabricator via llvm-commits]

rongjiecomputer created this revision.
rongjiecomputer added reviewers: samsonov, rnk.
Herald added subscribers: Sanitizers, llvm-commits, mgorny, dberris.

For some reason CMake can't find the `append` macro if LLVM is built separately and imported via `LLVM_CONFIG_PATH`.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43458

Files:
  CMakeLists.txt


Index: CMakeLists.txt
===================================================================
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -339,7 +339,7 @@
   # it, but CMake doesn't seem to have a way to set linker flags for
   # individual static libraries, so we enable the suppression flag for
   # the whole compiler-rt project.
-  append("/IGNORE:4221" CMAKE_STATIC_LINKER_FLAGS)
+  set(CMAKE_STATIC_LINKER_FLAGS "${CMAKE_STATIC_LINKER_FLAGS} /IGNORE:4221")
 endif()
 
 add_subdirectory(include)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43458.134897.patch
Type: text/x-patch
Size: 494 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180219/b624ca9f/attachment.bin>