[PATCH] D43241: [ELF] - Do not crash with --emit-relocs and --icf=all together.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 19 01:05:16 PST 2018


grimar added a comment.

In https://reviews.llvm.org/D43241#1006538, @ruiu wrote:

> `replace` is not designed to be smart, and adding new code there seems semantically incorrect, as replacing some section doesn't necessarily mean that its dependent sections should be marked as dead.
>
> You could instead add code to ICF.cpp.


Thanks, with that I was able to simplify code a bit more.


https://reviews.llvm.org/D43241





More information about the llvm-commits mailing list