[llvm] r325469 - [X86] Correct a typo I made in combineToExtendCMOV recently.
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 18 12:41:25 PST 2018
Author: ctopper
Date: Sun Feb 18 12:41:25 2018
New Revision: 325469
URL: http://llvm.org/viewvc/llvm-project?rev=325469&view=rev
Log:
[X86] Correct a typo I made in combineToExtendCMOV recently.
We're accidentally checking that the same node is a constant twice instead of checking the other node.
This isn't a functional problem since we didn't do anything below that explicitly requires constants. It just means we may have introduced a sign_extend or zero_extend that won't fold out.
Modified:
llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=325469&r1=325468&r2=325469&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sun Feb 18 12:41:25 2018
@@ -36066,7 +36066,7 @@ static SDValue combineToExtendCMOV(SDNod
SDValue CMovOp1 = CMovN.getOperand(1);
if (!isa<ConstantSDNode>(CMovOp0.getNode()) ||
- !isa<ConstantSDNode>(CMovOp0.getNode()))
+ !isa<ConstantSDNode>(CMovOp1.getNode()))
return SDValue();
// Only extend to i32 or i64.
More information about the llvm-commits
mailing list