[PATCH] D42948: [SelectionDAG] Support some SimplifySetCC cases for comparing against vector splats of constants.
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 18 08:17:57 PST 2018
spatel added a comment.
In https://reviews.llvm.org/D42948#1011601, @RKSimon wrote:
> In https://reviews.llvm.org/D42948#1007581, @spatel wrote:
>
> > We might have to be more careful with vector ISAs because they tend to leave out the full set of predicates. Ie, do we have to check for legal-or-custom if this transform can happen late, or can we assume that all predicates must be handled for all data types?
>
>
> Do you think we should override isCondCodeLegal?
No - that looks exactly like what I was thinking of. I just couldn't tell from the diffs if we're checking that consistently...so this patch should be good as-is (just rebased).
Refactoring to better organize this blob can be a follow-up. :)
Repository:
rL LLVM
https://reviews.llvm.org/D42948
More information about the llvm-commits
mailing list