[PATCH] D42356: [AArch64] Implement dynamic stack probing for windows

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 22:50:56 PST 2018


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

Thanks for refactoring it. LGTM with a minor comment addition.



================
Comment at: lib/CodeGen/GlobalISel/IRTranslator.cpp:1007
 
+  if (MF->getTarget().getTargetTriple().isOSWindows())
+    return false;
----------------
Please add a comment here explaining why Windows isn't supported.


https://reviews.llvm.org/D42356





More information about the llvm-commits mailing list