[lld] r325406 - Do not print out "no input files" twice.

[Rui Ueyama via llvm-commits]

Author: ruiu
Date: Fri Feb 16 14:58:19 2018
New Revision: 325406

URL: http://llvm.org/viewvc/llvm-project?rev=325406&view=rev
Log:
Do not print out "no input files" twice.

Differential Revision: https://reviews.llvm.org/D43408

Added:
    lld/trunk/test/wasm/driver.ll
Modified:
    lld/trunk/wasm/Driver.cpp

Added: lld/trunk/test/wasm/driver.ll
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/wasm/driver.ll?rev=325406&view=auto
==============================================================================
--- lld/trunk/test/wasm/driver.ll (added)
+++ lld/trunk/test/wasm/driver.ll Fri Feb 16 14:58:19 2018
@@ -0,0 +1,18 @@
+; RUN: llc -filetype=obj %s -o %t.o
+
+target triple = "wasm32-unknown-unknown-wasm"
+
+define hidden void @entry() local_unnamed_addr #0 {
+entry:
+  ret void
+}
+
+; RUN: not wasm-ld -o %t.exe 2>&1 | FileCheck -check-prefix=IN %s
+; IN: error: no input files
+
+; RUN: not wasm-ld %t.o 2>&1 | FileCheck -check-prefix=OUT %s
+; OUT: error: no output file specified
+
+; RUN: not wasm-ld 2>&1 | FileCheck -check-prefix=BOTH %s
+; BOTH:     error: no input files
+; BOTH-NOT: error: no output file specified

Modified: lld/trunk/wasm/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/wasm/Driver.cpp?rev=325406&r1=325405&r2=325406&view=diff
==============================================================================
--- lld/trunk/wasm/Driver.cpp (original)
+++ lld/trunk/wasm/Driver.cpp Fri Feb 16 14:58:19 2018
@@ -211,9 +211,6 @@ void LinkerDriver::createFiles(opt::Inpu
       break;
     }
   }
-
-  if (Files.empty())
-    error("no input files");
 }
 
 static StringRef getEntry(opt::InputArgList &Args, StringRef Default) {
@@ -280,12 +277,14 @@ void LinkerDriver::link(ArrayRef<const c
   if (auto *Arg = Args.getLastArg(OPT_allow_undefined_file))
     readImportFile(Arg->getValue());
 
+  if (!Args.hasArg(OPT_INPUT)) {
+    error("no input files");
+    return;
+  }
+
   if (Config->OutputFile.empty())
     error("no output file specified");
 
-  if (!Args.hasArg(OPT_INPUT))
-    error("no input files");
-
   if (Config->Relocatable) {
     if (!Config->Entry.empty())
       error("entry point specified for relocatable output file");