[PATCH] D43387: [DebugInfo] Removed assert on missing CountVarDIE

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 13:09:44 PST 2018


sdesmalen added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1388
+    else
+      ; // Should this case be handled?
   } else if (Count != -1)
----------------
aprantl wrote:
> That else statement was more meant as a question for you :-)
> 
Ahh, I wasn't sure :-) So if there is not enough information about the 'count' at the point of arriving here, there isn't much else you can do than not generating the information. Of course it is best to make sure this doesn't happen without a good reason (hence https://reviews.llvm.org/D43386).


https://reviews.llvm.org/D43387





More information about the llvm-commits mailing list