[PATCH] D43406: Merge two small functions and add comments.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 13:01:30 PST 2018


sbc100 added inline comments.


================
Comment at: lld/wasm/InputChunks.cpp:79
 
-static void applyRelocations(uint8_t *Buf, ArrayRef<OutputRelocation> Relocs) {
-  if (!Relocs.size())
+// Copy this input chunk to an mmap'ed output file.
+void InputChunk::writeTo(uint8_t *Buf) const {
----------------
ruiu wrote:
> sbc100 wrote:
> > How do you feel about documentation here vs declaration in the .h file?   
> Why not both? :)
Not sure that makes sense.  It means the old probably of comments being out-of-date is now double because the can also be out of date with themselves! :)


https://reviews.llvm.org/D43406





More information about the llvm-commits mailing list