[PATCH] D43399: [WebAssembly] Fix bug is function signature checking

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 12:46:59 PST 2018


ncw added a comment.

That's great, thanks for splitting it out. The longer-term fix I think is to just set FunctionType always (for defined and undefined symbols), rather than have the confusion of a member that's sometimes meaningful and sometimes not; less error-prone to keep the values of all the members in sync with each other (where meaningful).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43399





More information about the llvm-commits mailing list