[PATCH] D43401: [lld/LTO] Remove unused Path parameter to AddBufferFn
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 16 12:17:43 PST 2018
LGTM
Teresa Johnson via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:
> tejohnson created this revision.
> tejohnson added a reviewer: pcc.
> Herald added subscribers: arichardson, inglorion, emaste.
>
> With https://reviews.llvm.org/D43396, no clients use the Path parameter anymore.
> This is the lld side fix with https://reviews.llvm.org/D43400.
>
> Depends on https://reviews.llvm.org/D43396 and https://reviews.llvm.org/D43400.
>
>
> Repository:
> rLLD LLVM Linker
>
> https://reviews.llvm.org/D43401
>
> Files:
> COFF/LTO.cpp
> ELF/LTO.cpp
>
>
> Index: ELF/LTO.cpp
> ===================================================================
> --- ELF/LTO.cpp
> +++ ELF/LTO.cpp
> @@ -190,8 +190,9 @@
> if (!Config->ThinLTOCacheDir.empty())
> Cache = check(
> lto::localCache(Config->ThinLTOCacheDir,
> - [&](size_t Task, std::unique_ptr<MemoryBuffer> MB,
> - StringRef Path) { Files[Task] = std::move(MB); }));
> + [&](size_t Task, std::unique_ptr<MemoryBuffer> MB) {
> + Files[Task] = std::move(MB);
> + }));
>
> checkError(LTOObj->run(
> [&](size_t Task) {
> Index: COFF/LTO.cpp
> ===================================================================
> --- COFF/LTO.cpp
> +++ COFF/LTO.cpp
> @@ -127,10 +127,10 @@
> // specified, configure LTO to use it as the cache directory.
> lto::NativeObjectCache Cache;
> if (!Config->LTOCache.empty())
> - Cache = check(
> - lto::localCache(Config->LTOCache,
> - [&](size_t Task, std::unique_ptr<MemoryBuffer> MB,
> - StringRef Path) { Files[Task] = std::move(MB); }));
> + Cache = check(lto::localCache(
> + Config->LTOCache, [&](size_t Task, std::unique_ptr<MemoryBuffer> MB) {
> + Files[Task] = std::move(MB);
> + }));
>
> checkError(LTOObj->run(
> [&](size_t Task) {
>
>
> Index: ELF/LTO.cpp
> ===================================================================
> --- ELF/LTO.cpp
> +++ ELF/LTO.cpp
> @@ -190,8 +190,9 @@
> if (!Config->ThinLTOCacheDir.empty())
> Cache = check(
> lto::localCache(Config->ThinLTOCacheDir,
> - [&](size_t Task, std::unique_ptr<MemoryBuffer> MB,
> - StringRef Path) { Files[Task] = std::move(MB); }));
> + [&](size_t Task, std::unique_ptr<MemoryBuffer> MB) {
> + Files[Task] = std::move(MB);
> + }));
>
> checkError(LTOObj->run(
> [&](size_t Task) {
> Index: COFF/LTO.cpp
> ===================================================================
> --- COFF/LTO.cpp
> +++ COFF/LTO.cpp
> @@ -127,10 +127,10 @@
> // specified, configure LTO to use it as the cache directory.
> lto::NativeObjectCache Cache;
> if (!Config->LTOCache.empty())
> - Cache = check(
> - lto::localCache(Config->LTOCache,
> - [&](size_t Task, std::unique_ptr<MemoryBuffer> MB,
> - StringRef Path) { Files[Task] = std::move(MB); }));
> + Cache = check(lto::localCache(
> + Config->LTOCache, [&](size_t Task, std::unique_ptr<MemoryBuffer> MB) {
> + Files[Task] = std::move(MB);
> + }));
>
> checkError(LTOObj->run(
> [&](size_t Task) {
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list