[lld] r325379 - Don't depend on "call foo" producing a X86_64_PC32.
Rafael Espindola via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 16 12:05:58 PST 2018
Author: rafael
Date: Fri Feb 16 12:05:58 2018
New Revision: 325379
URL: http://llvm.org/viewvc/llvm-project?rev=325379&view=rev
Log:
Don't depend on "call foo" producing a X86_64_PC32.
Newer versions of the gnu assembler produce a X86_64_PLT32 for
calls. There is a change under review in llvm to do the same, so update
the tests to not depend on it.
We can still produce a R_X86_64_PC32 with ".long foo - .".
Modified:
lld/trunk/test/ELF/copy-errors.s
lld/trunk/test/ELF/copy-rel-corrupted.s
lld/trunk/test/ELF/copy-rel-pie.s
lld/trunk/test/ELF/gc-sections-shared.s
lld/trunk/test/ELF/map-file.s
lld/trunk/test/ELF/non-abs-reloc.s
lld/trunk/test/ELF/relocatable-symbols.s
lld/trunk/test/ELF/verdef-defaultver.s
lld/trunk/test/ELF/writable-sec-plt-reloc.s
lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s
lld/trunk/test/ELF/znotext-plt-relocations-protected.s
Modified: lld/trunk/test/ELF/copy-errors.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/copy-errors.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/copy-errors.s (original)
+++ lld/trunk/test/ELF/copy-errors.s Fri Feb 16 12:05:58 2018
@@ -19,5 +19,7 @@
.global _start
_start:
-call bar
-call zed
+.byte 0xe8
+.long bar - .
+.byte 0xe8
+.long zed - .
Modified: lld/trunk/test/ELF/copy-rel-corrupted.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/copy-rel-corrupted.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/copy-rel-corrupted.s (original)
+++ lld/trunk/test/ELF/copy-rel-corrupted.s Fri Feb 16 12:05:58 2018
@@ -7,4 +7,4 @@
.global _start
_start:
- call x
+ .long x - .
Modified: lld/trunk/test/ELF/copy-rel-pie.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/copy-rel-pie.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/copy-rel-pie.s (original)
+++ lld/trunk/test/ELF/copy-rel-pie.s Fri Feb 16 12:05:58 2018
@@ -7,8 +7,10 @@
.global _start
_start:
- call bar
- call foo
+ .byte 0xe8
+ .long bar - . -4
+ .byte 0xe8
+ .long foo - . -4
// CHECK: Name: .plt
// CHECK-NEXT: Type: SHT_PROGBITS
Modified: lld/trunk/test/ELF/gc-sections-shared.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/gc-sections-shared.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/gc-sections-shared.s (original)
+++ lld/trunk/test/ELF/gc-sections-shared.s Fri Feb 16 12:05:58 2018
@@ -125,7 +125,7 @@
.section .text.foo, "ax"
.globl foo
foo:
-call bar
+.long bar - .
.section .text.bar, "ax"
.globl bar
@@ -136,9 +136,9 @@ ret
.globl _start
.weak qux
_start:
-call baz
-call qux
+.long baz - .
+.long qux - .
ret
.section .text.unused, "ax"
-call bar2
+.long bar2 - .
Modified: lld/trunk/test/ELF/map-file.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/map-file.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/map-file.s (original)
+++ lld/trunk/test/ELF/map-file.s Fri Feb 16 12:05:58 2018
@@ -17,9 +17,12 @@
_start:
.quad sharedFoo
.quad sharedBar
- callq sharedFunc1
- callq sharedFunc2
- call baz
+ .byte 0xe8
+ .long sharedFunc1 - .
+ .byte 0xe8
+ .long sharedFunc2 - .
+ .byte 0xe8
+ .long baz - .
.global _Z1fi
_Z1fi:
.cfi_startproc
Modified: lld/trunk/test/ELF/non-abs-reloc.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/non-abs-reloc.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/non-abs-reloc.s (original)
+++ lld/trunk/test/ELF/non-abs-reloc.s Fri Feb 16 12:05:58 2018
@@ -15,5 +15,7 @@ _start:
nop
.section .nonalloc
- call _start
- call _start
+ .byte 0xe8
+ .long _start - . - 4
+ .byte 0xe8
+ .long _start - . - 4
Modified: lld/trunk/test/ELF/relocatable-symbols.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/relocatable-symbols.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/relocatable-symbols.s (original)
+++ lld/trunk/test/ELF/relocatable-symbols.s Fri Feb 16 12:05:58 2018
@@ -174,21 +174,33 @@
.global _start
.text
_start:
- call __start_foo
- call __stop_foo
+ .byte 0xe8
+ .long __start_foo - . -4
+ .byte 0xe8
+ .long __stop_foo - . -4
- call __start_bar
- call __stop_bar
+ .byte 0xe8
+ .long __start_bar - . -4
+ .byte 0xe8
+ .long __stop_bar - . -4
- call __start_doo
- call __stop_doo
+ .byte 0xe8
+ .long __start_doo - . -4
+ .byte 0xe8
+ .long __stop_doo - . -4
- call __preinit_array_start
- call __preinit_array_end
- call __init_array_start
- call __init_array_end
- call __fini_array_start
- call __fini_array_end
+ .byte 0xe8
+ .long __preinit_array_start - . -4
+ .byte 0xe8
+ .long __preinit_array_end - . -4
+ .byte 0xe8
+ .long __init_array_start - . -4
+ .byte 0xe8
+ .long __init_array_end - . -4
+ .byte 0xe8
+ .long __fini_array_start - . -4
+ .byte 0xe8
+ .long __fini_array_end - . -4
.section foo,"ax"
nop
Modified: lld/trunk/test/ELF/verdef-defaultver.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/verdef-defaultver.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/verdef-defaultver.s (original)
+++ lld/trunk/test/ELF/verdef-defaultver.s Fri Feb 16 12:05:58 2018
@@ -196,6 +196,6 @@
.globl _start
_start:
- callq a
- callq b
- callq c
+ .long a - .
+ .long b - .
+ .long c - .
Modified: lld/trunk/test/ELF/writable-sec-plt-reloc.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/writable-sec-plt-reloc.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/writable-sec-plt-reloc.s (original)
+++ lld/trunk/test/ELF/writable-sec-plt-reloc.s Fri Feb 16 12:05:58 2018
@@ -11,4 +11,4 @@
.section .bar,"awx"
.global _start
_start:
- call foo
+ .long foo - .
Modified: lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s (original)
+++ lld/trunk/test/ELF/x86-64-reloc-pc32-fpic.s Fri Feb 16 12:05:58 2018
@@ -7,4 +7,5 @@
# CHECK: >>> referenced by {{.*}}:(.data+0x1)
.data
-call _shared
+ .byte 0xe8
+ .long _shared - .
Modified: lld/trunk/test/ELF/znotext-plt-relocations-protected.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/znotext-plt-relocations-protected.s?rev=325379&r1=325378&r2=325379&view=diff
==============================================================================
--- lld/trunk/test/ELF/znotext-plt-relocations-protected.s (original)
+++ lld/trunk/test/ELF/znotext-plt-relocations-protected.s Fri Feb 16 12:05:58 2018
@@ -8,4 +8,4 @@
.global _start
_start:
-callq foo
+ .long foo - .
More information about the llvm-commits
mailing list