[PATCH] D43361: [ThinLTO] Enable AutoHide on symbols with local_unnamed_addr

[Steven Wu via Phabricator via llvm-commits]

steven_wu added a comment.

I am using local_unnamed_addr as an example. Maybe you are right but I think my point is still valid. That is, LTO optimization and code generation can modify the symbol table from the bitcode file. It is already the case that symbols can be internalized, removed, backend can also insert new symbols.. Unless there is a rule saying LTO passes cannot modify the linkage or visibility or any other attributes to the symbols, linker cannot trust whatever the bitcode symbol table says and firmly it will not be changed for some good reason.

In this case, if the unnamed_addr attributes are not illegal to change, the linkage can be changed which effectively disable autohide on the symbol.


Repository:
  rL LLVM

https://reviews.llvm.org/D43361