[PATCH] D37515: [mips] Generate memory dependencies for byVal arguments

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 07:23:49 PST 2018


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LGTM. Add a comment to test file, describing the purpose of the test.



================
Comment at: lib/Target/Mips/MipsISelLowering.cpp:4105
 
   // Create frame object.
   EVT PtrTy = getPointerTy(DAG.getDataLayout());
----------------
Expand the comment here on why we're marking the object as mutable + isAliased.


https://reviews.llvm.org/D37515





More information about the llvm-commits mailing list