[PATCH] D43330: [gtest] Add PrintTo overload for StringRef.

Ilya Biryukov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 16 04:39:57 PST 2018


ilya-biryukov added inline comments.


================
Comment at: utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h:48
+inline void PrintTo(const llvm::StringRef &Val, std::ostream *S) {
+  if (!S)
+    return;
----------------
sammccall wrote:
> I think this is dead code, gtest won't call in this case
Replaced with assertion


Repository:
  rL LLVM

https://reviews.llvm.org/D43330





More information about the llvm-commits mailing list