[PATCH] D31528: [ELF][MIPS] Multi-GOT implementation

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

Thank you very much for updating this patch! I have just made the switch in CheriBSD to completely stop using ld.bfd and so far everything I have tested is working.



================
Comment at: ELF/SyntheticSections.cpp:911
+      if (P.first->IsPreemptible)
+        InX::RelaDyn->addReloc(
+            {Target->TlsGotRel, this, Offset, false, P.first, 0});
----------------
This could probably use the 4 argument overload since there is no addend.


================
Comment at: ELF/SyntheticSections.cpp:920
+        InX::RelaDyn->addReloc(
+            {Target->TlsModuleIndexRel, this, Offset, false, nullptr, 0});
+      } else {
----------------
Same for the following 3 calls.


================
Comment at: ELF/SyntheticSections.h:402
+  // lie inside the output section.
+  DynamicReloc(uint32_t Type, const InputSectionBase *InputSec,
+               uint64_t OffsetInSec, const OutputSection *OutputSec,
----------------
`RelType Type`


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D31528