[PATCH] D43338: [SelectionDAG] ComputeNumSignBits - add support for SMIN+SMAX clamp patterns

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 22:22:12 PST 2018


craig.topper added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3212
+    // the minimum of the clamp min/max range.
+    bool IsMax = (Opcode == ISD::SMAX || Opcode == ISD::UMAX);
+    ConstantSDNode *CstLow = nullptr, *CstHigh = nullptr;
----------------
Opcode can't ever be UMAX here right? Was this supposed to SMIN?


Repository:
  rL LLVM

https://reviews.llvm.org/D43338





More information about the llvm-commits mailing list