[PATCH] D43369: ELF: Stop collecting a list of symbols in ArchiveFile.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 21:16:31 PST 2018


pcc planned changes to this revision.
pcc added inline comments.


================
Comment at: lld/ELF/Driver.cpp:998
         for (Symbol *Sym : File->getSymbols())
           if (!Sym->isLocal())
             Sym->VersionId = VER_NDX_LOCAL;
----------------
Wait, this isn't quite right yet, I think we need to check `Sym->File == File` here now.


https://reviews.llvm.org/D43369





More information about the llvm-commits mailing list