[PATCH] D43264: [WebAssembly] Add explicit symbol table

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 19:10:11 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D43264#1009610, @ncw wrote:

> I see about "imported", thanks! I hadn't realized that terminology in DSOs, my mistake. In wasm "imported" really is undefined.
>
> Maybe we could compromise on keeping InputGlobal, but renaming it and making it not derive from InputChunk. That would almost compile as-is in fact, and I think maybe you've right that would be cleaner. MarkLive would have to gain support for it, but that's only a few lines of code actually.
>
> I could try that tomorrow, or Sam could try now?


I've been trying to do this this evening but its fairly entangled.  I will try again tomorrow, perhaps with a preparatory change to precede it.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43264





More information about the llvm-commits mailing list