[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 18:22:05 PST 2018


dblaikie added a comment.

Seems awkward/not ideal to compute the start/end, then reverse those computations to compute the values appropriate to print in verbose mode - probably better to keep the original values & compute the final values when needed/printing?

Also I think there's probably some similar printing logic, maybe for the debug_loc.dwo section? Maybe check that to see how the different kinds of address range specifications (start+length, start+end, base address specifier, etc) are printed there & whether there's some uniformity that can be applied/reused/improved here?


https://reviews.llvm.org/D43366





More information about the llvm-commits mailing list