[PATCH] D43264: [WebAssembly] Add explicit symbol table

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 17:20:34 PST 2018


ruiu added a comment.

> We could simply store the wasm global data in the DefinedGlobal itself, rather then having it point to an InputGlobal.  I think the problem there is when more than one symbol aliases the same global.   But, we don't have the case yet so perhaps we can push that down the line a little.   Let me see if I can simplify things.

What is your concern on aliasing? In general, symbols can have aliases (by just pointing to the same offset in the same section). We don't do anything special about it in other file formats, and it just works fine -- we don't need to find if a symbol has aliases or not to generate a correct output. I'm wondering if there's some wasm-specific concern about it.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43264





More information about the llvm-commits mailing list