[PATCH] D41104: Set the NoRecurse attribute for the dbg intrinsics.

Matt Davis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 15:41:04 PST 2018


mattd added a comment.

I'm happy to take a look at cleaning up the isLoweredToCall().  Taking a hint from the comment in that routine, I think it makes sense to move that logic to another class, perhaps the base TargetLowering class, after all, this routine is about lowering.

I'm not sure what you all had in mind.  The solution I am thinking of would make isLoweredToCall a virtual function in TargetLowering.  Each target-specific implementation of TargetLowering could override that routine to handle specific instructions that may/may-not  be lowered to a call.  As an initial pass we could take the routine as it is now and make that the default behavior, which doesn't change functionality, but opens the doors for other targets to make use of this functionality later.   Additionally, I think it would be nice to avoid the string matching on instruction names in the body, but that would probably need to be a target-specific solution.


https://reviews.llvm.org/D41104





More information about the llvm-commits mailing list