[PATCH] D43351: Relax relocation type checking in a non-ALLOC section.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 13:49:08 PST 2018


Without this patch, SBCL doesn't work. I don't understand its internals,
but apparently SBCL depends on the relocated values.

On Thu, Feb 15, 2018 at 1:48 PM, Rui Ueyama <ruiu at google.com> wrote:

> One example is SBCL. I believe this is the code where it generates PC32
> relocations against non-ALLOC section, but I may be wrong.
>
> https://github.com/sbcl/sbcl/blob/ea395cb6fb53f04e081254738c1cdc
> 1f3e6fef7f/tools-for-build/editcore.lisp#L958
>
> GNU linkers relocate such relocations as if they were at address 0, as I
> wrote in the comment. With this patch. SBCL works.
>
> On Thu, Feb 15, 2018 at 1:46 PM, Rui Ueyama via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> ruiu updated this revision to Diff 134502.
>> ruiu added a comment.
>>
>> - fix typos in test
>>
>>
>> https://reviews.llvm.org/D43351
>>
>> Files:
>>   lld/ELF/InputSection.cpp
>>   lld/test/ELF/invalid/invalid-debug-relocations.test
>>   lld/test/ELF/non-abs-reloc.s
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180215/187425fe/attachment.html>


More information about the llvm-commits mailing list