[PATCH] D43156: Allow disabling PDB generation in Release build

[Reid Kleckner via Phabricator via llvm-commits]

rnk requested changes to this revision.
rnk added inline comments.
This revision now requires changes to proceed.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:357
   # Generate PDB even in release for profiling.
-  if (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE")
+  option(LLVM_ENABLE_PDB ON)
+  if (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE" AND LLVM_ENABLE_PDB)
----------------
Let's just make this OFF by default.


================
Comment at: cmake/modules/HandleLLVMOptions.cmake:358
+  option(LLVM_ENABLE_PDB ON)
+  if (uppercase_CMAKE_BUILD_TYPE STREQUAL "RELEASE" AND LLVM_ENABLE_PDB)
     append("/Zi" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
I'd switch the condition order, so we check if we're enabling PDBs first, then look at the build type.

There are other build types that we might wish to handle later, but just doing this in Release is fine for now.


https://reviews.llvm.org/D43156