[PATCH] D34554: [ELF] FIx use-after-return of archive path

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 15 10:32:09 PST 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/ELF/whole-archive-name.s:8
+// RUN: llvm-ar rcs %t.dir/libfoo.a %tfoo.o
+// RUN: ld.lld -L%t.dir %t.o --whole-archive -lfoo -o %t -Map=- | FileCheck %s
+
----------------
I think you can remove test/ELF/Inputs/whole-archive-name.s because you only need single .s file. Since --whole-archive links everything, you don't need to pass any .o file. I.e. you can just pass an .a file.


https://reviews.llvm.org/D34554





More information about the llvm-commits mailing list