[PATCH] D43330: [gtest] Add PrintTo overload for StringRef.
Sam McCall via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 15 10:01:24 PST 2018
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
LG, but good idea to wait on more input
================
Comment at: utils/unittest/googletest/include/gtest/internal/custom/gtest-printers.h:48
+inline void PrintTo(const llvm::StringRef &Val, std::ostream *S) {
+ if (!S)
+ return;
----------------
I think this is dead code, gtest won't call in this case
Repository:
rL LLVM
https://reviews.llvm.org/D43330
More information about the llvm-commits
mailing list