[llvm] r325247 - [InstCombine] allow sin/cos transforms with 'reassoc'
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 15 07:07:12 PST 2018
Author: spatel
Date: Thu Feb 15 07:07:12 2018
New Revision: 325247
URL: http://llvm.org/viewvc/llvm-project?rev=325247&view=rev
Log:
[InstCombine] allow sin/cos transforms with 'reassoc'
The variable name 'AllowReassociate' is a lie at this point because
it's set to 'isFast()' which is more than the 'reassoc' FMF after
rL317488.
In D41286, we showed that this transform may be valid even with strict
math by brute force checking every 32-bit float result.
There's a potential problem here because we're replacing with a tan()
libcall rather than a hypothetical LLVM tan intrinsic. So we might
set errno when we should be guaranteed not to do that. But that's
independent of this change.
Modified:
llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
llvm/trunk/test/Transforms/InstCombine/fdiv-cos-sin.ll
llvm/trunk/test/Transforms/InstCombine/fdiv-sin-cos.ll
Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp?rev=325247&r1=325246&r2=325247&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp (original)
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp Thu Feb 15 07:07:12 2018
@@ -1461,8 +1461,7 @@ Instruction *InstCombiner::visitFDiv(Bin
}
}
- if (AllowReassociate &&
- Op0->hasOneUse() && Op1->hasOneUse()) {
+ if (I.hasAllowReassoc() && Op0->hasOneUse() && Op1->hasOneUse()) {
Value *A;
// sin(a) / cos(a) -> tan(a)
if (match(Op0, m_Intrinsic<Intrinsic::sin>(m_Value(A))) &&
Modified: llvm/trunk/test/Transforms/InstCombine/fdiv-cos-sin.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/fdiv-cos-sin.ll?rev=325247&r1=325246&r2=325247&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/fdiv-cos-sin.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/fdiv-cos-sin.ll Thu Feb 15 07:07:12 2018
@@ -14,91 +14,91 @@ define double @fdiv_cos_sin(double %a) {
ret double %div
}
-define double @fdiv_strict_cos_strict_sin_fast(double %a) {
-; CHECK-LABEL: @fdiv_strict_cos_strict_sin_fast(
+define double @fdiv_strict_cos_strict_sin_reassoc(double %a) {
+; CHECK-LABEL: @fdiv_strict_cos_strict_sin_reassoc(
; CHECK-NEXT: [[TMP1:%.*]] = call double @llvm.cos.f64(double [[A:%.*]])
-; CHECK-NEXT: [[TMP2:%.*]] = call fast double @llvm.sin.f64(double [[A]])
+; CHECK-NEXT: [[TMP2:%.*]] = call reassoc double @llvm.sin.f64(double [[A]])
; CHECK-NEXT: [[DIV:%.*]] = fdiv double [[TMP1]], [[TMP2]]
; CHECK-NEXT: ret double [[DIV]]
;
%1 = call double @llvm.cos.f64(double %a)
- %2 = call fast double @llvm.sin.f64(double %a)
+ %2 = call reassoc double @llvm.sin.f64(double %a)
%div = fdiv double %1, %2
ret double %div
}
-define double @fdiv_fast_cos_strict_sin_strict(double %a, i32* dereferenceable(2) %dummy) {
-; CHECK-LABEL: @fdiv_fast_cos_strict_sin_strict(
-; CHECK-NEXT: [[TAN:%.*]] = call fast double @tan(double [[A:%.*]]) #1
-; CHECK-NEXT: [[TMP1:%.*]] = fdiv fast double 1.000000e+00, [[TAN]]
+define double @fdiv_reassoc_cos_strict_sin_strict(double %a, i32* dereferenceable(2) %dummy) {
+; CHECK-LABEL: @fdiv_reassoc_cos_strict_sin_strict(
+; CHECK-NEXT: [[TAN:%.*]] = call reassoc double @tan(double [[A:%.*]]) #1
+; CHECK-NEXT: [[TMP1:%.*]] = fdiv reassoc double 1.000000e+00, [[TAN]]
; CHECK-NEXT: ret double [[TMP1]]
;
%1 = call double @llvm.cos.f64(double %a)
%2 = call double @llvm.sin.f64(double %a)
- %div = fdiv fast double %1, %2
+ %div = fdiv reassoc double %1, %2
ret double %div
}
-define double @fdiv_fast_cos_fast_sin_strict(double %a) {
-; CHECK-LABEL: @fdiv_fast_cos_fast_sin_strict(
-; CHECK-NEXT: [[TAN:%.*]] = call fast double @tan(double [[A:%.*]]) #1
-; CHECK-NEXT: [[TMP1:%.*]] = fdiv fast double 1.000000e+00, [[TAN]]
+define double @fdiv_reassoc_cos_reassoc_sin_strict(double %a) {
+; CHECK-LABEL: @fdiv_reassoc_cos_reassoc_sin_strict(
+; CHECK-NEXT: [[TAN:%.*]] = call reassoc double @tan(double [[A:%.*]]) #1
+; CHECK-NEXT: [[TMP1:%.*]] = fdiv reassoc double 1.000000e+00, [[TAN]]
; CHECK-NEXT: ret double [[TMP1]]
;
- %1 = call fast double @llvm.cos.f64(double %a)
+ %1 = call reassoc double @llvm.cos.f64(double %a)
%2 = call double @llvm.sin.f64(double %a)
- %div = fdiv fast double %1, %2
+ %div = fdiv reassoc double %1, %2
ret double %div
}
-define double @fdiv_cos_sin_fast_multiple_uses(double %a) {
-; CHECK-LABEL: @fdiv_cos_sin_fast_multiple_uses(
-; CHECK-NEXT: [[TMP1:%.*]] = call fast double @llvm.cos.f64(double [[A:%.*]])
-; CHECK-NEXT: [[TMP2:%.*]] = call fast double @llvm.sin.f64(double [[A]])
-; CHECK-NEXT: [[DIV:%.*]] = fdiv fast double [[TMP1]], [[TMP2]]
+define double @fdiv_cos_sin_reassoc_multiple_uses(double %a) {
+; CHECK-LABEL: @fdiv_cos_sin_reassoc_multiple_uses(
+; CHECK-NEXT: [[TMP1:%.*]] = call reassoc double @llvm.cos.f64(double [[A:%.*]])
+; CHECK-NEXT: [[TMP2:%.*]] = call reassoc double @llvm.sin.f64(double [[A]])
+; CHECK-NEXT: [[DIV:%.*]] = fdiv reassoc double [[TMP1]], [[TMP2]]
; CHECK-NEXT: call void @use(double [[TMP2]])
; CHECK-NEXT: ret double [[DIV]]
;
- %1 = call fast double @llvm.cos.f64(double %a)
- %2 = call fast double @llvm.sin.f64(double %a)
- %div = fdiv fast double %1, %2
+ %1 = call reassoc double @llvm.cos.f64(double %a)
+ %2 = call reassoc double @llvm.sin.f64(double %a)
+ %div = fdiv reassoc double %1, %2
call void @use(double %2)
ret double %div
}
-define double @fdiv_cos_sin_fast(double %a) {
-; CHECK-LABEL: @fdiv_cos_sin_fast(
-; CHECK-NEXT: [[TAN:%.*]] = call fast double @tan(double [[A:%.*]]) #1
-; CHECK-NEXT: [[TMP1:%.*]] = fdiv fast double 1.000000e+00, [[TAN]]
+define double @fdiv_cos_sin_reassoc(double %a) {
+; CHECK-LABEL: @fdiv_cos_sin_reassoc(
+; CHECK-NEXT: [[TAN:%.*]] = call reassoc double @tan(double [[A:%.*]]) #1
+; CHECK-NEXT: [[TMP1:%.*]] = fdiv reassoc double 1.000000e+00, [[TAN]]
; CHECK-NEXT: ret double [[TMP1]]
;
- %1 = call fast double @llvm.cos.f64(double %a)
- %2 = call fast double @llvm.sin.f64(double %a)
- %div = fdiv fast double %1, %2
+ %1 = call reassoc double @llvm.cos.f64(double %a)
+ %2 = call reassoc double @llvm.sin.f64(double %a)
+ %div = fdiv reassoc double %1, %2
ret double %div
}
-define float @fdiv_cosf_sinf_fast(float %a) {
-; CHECK-LABEL: @fdiv_cosf_sinf_fast(
-; CHECK-NEXT: [[TANF:%.*]] = call fast float @tanf(float [[A:%.*]]) #1
-; CHECK-NEXT: [[TMP1:%.*]] = fdiv fast float 1.000000e+00, [[TANF]]
+define float @fdiv_cosf_sinf_reassoc(float %a) {
+; CHECK-LABEL: @fdiv_cosf_sinf_reassoc(
+; CHECK-NEXT: [[TANF:%.*]] = call reassoc float @tanf(float [[A:%.*]]) #1
+; CHECK-NEXT: [[TMP1:%.*]] = fdiv reassoc float 1.000000e+00, [[TANF]]
; CHECK-NEXT: ret float [[TMP1]]
;
- %1 = call fast float @llvm.cos.f32(float %a)
- %2 = call fast float @llvm.sin.f32(float %a)
- %div = fdiv fast float %1, %2
+ %1 = call reassoc float @llvm.cos.f32(float %a)
+ %2 = call reassoc float @llvm.sin.f32(float %a)
+ %div = fdiv reassoc float %1, %2
ret float %div
}
-define fp128 @fdiv_cosfp128_sinfp128_fast(fp128 %a) {
-; CHECK-LABEL: @fdiv_cosfp128_sinfp128_fast(
-; CHECK-NEXT: [[TANL:%.*]] = call fast fp128 @tanl(fp128 [[A:%.*]]) #1
-; CHECK-NEXT: [[TMP1:%.*]] = fdiv fast fp128 0xL00000000000000003FFF000000000000, [[TANL]]
+define fp128 @fdiv_cosfp128_sinfp128_reassoc(fp128 %a) {
+; CHECK-LABEL: @fdiv_cosfp128_sinfp128_reassoc(
+; CHECK-NEXT: [[TANL:%.*]] = call reassoc fp128 @tanl(fp128 [[A:%.*]]) #1
+; CHECK-NEXT: [[TMP1:%.*]] = fdiv reassoc fp128 0xL00000000000000003FFF000000000000, [[TANL]]
; CHECK-NEXT: ret fp128 [[TMP1]]
;
- %1 = call fast fp128 @llvm.cos.fp128(fp128 %a)
- %2 = call fast fp128 @llvm.sin.fp128(fp128 %a)
- %div = fdiv fast fp128 %1, %2
+ %1 = call reassoc fp128 @llvm.cos.fp128(fp128 %a)
+ %2 = call reassoc fp128 @llvm.sin.fp128(fp128 %a)
+ %div = fdiv reassoc fp128 %1, %2
ret fp128 %div
}
Modified: llvm/trunk/test/Transforms/InstCombine/fdiv-sin-cos.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/fdiv-sin-cos.ll?rev=325247&r1=325246&r2=325247&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/InstCombine/fdiv-sin-cos.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/fdiv-sin-cos.ll Thu Feb 15 07:07:12 2018
@@ -14,86 +14,86 @@ define double @fdiv_sin_cos(double %a) {
ret double %div
}
-define double @fdiv_strict_sin_strict_cos_fast(double %a) {
-; CHECK-LABEL: @fdiv_strict_sin_strict_cos_fast(
+define double @fdiv_strict_sin_strict_cos_reassoc(double %a) {
+; CHECK-LABEL: @fdiv_strict_sin_strict_cos_reassoc(
; CHECK-NEXT: [[TMP1:%.*]] = call double @llvm.sin.f64(double [[A:%.*]])
-; CHECK-NEXT: [[TMP2:%.*]] = call fast double @llvm.cos.f64(double [[A]])
+; CHECK-NEXT: [[TMP2:%.*]] = call reassoc double @llvm.cos.f64(double [[A]])
; CHECK-NEXT: [[DIV:%.*]] = fdiv double [[TMP1]], [[TMP2]]
; CHECK-NEXT: ret double [[DIV]]
;
%1 = call double @llvm.sin.f64(double %a)
- %2 = call fast double @llvm.cos.f64(double %a)
+ %2 = call reassoc double @llvm.cos.f64(double %a)
%div = fdiv double %1, %2
ret double %div
}
-define double @fdiv_fast_sin_strict_cos_strict(double %a, i32* dereferenceable(2) %dummy) {
-; CHECK-LABEL: @fdiv_fast_sin_strict_cos_strict(
-; CHECK-NEXT: [[TAN:%.*]] = call fast double @tan(double [[A:%.*]]) #1
+define double @fdiv_reassoc_sin_strict_cos_strict(double %a, i32* dereferenceable(2) %dummy) {
+; CHECK-LABEL: @fdiv_reassoc_sin_strict_cos_strict(
+; CHECK-NEXT: [[TAN:%.*]] = call reassoc double @tan(double [[A:%.*]]) #1
; CHECK-NEXT: ret double [[TAN]]
;
%1 = call double @llvm.sin.f64(double %a)
%2 = call double @llvm.cos.f64(double %a)
- %div = fdiv fast double %1, %2
+ %div = fdiv reassoc double %1, %2
ret double %div
}
-define double @fdiv_fast_sin_fast_cos_strict(double %a) {
-; CHECK-LABEL: @fdiv_fast_sin_fast_cos_strict(
-; CHECK-NEXT: [[TAN:%.*]] = call fast double @tan(double [[A:%.*]]) #1
+define double @fdiv_reassoc_sin_reassoc_cos_strict(double %a) {
+; CHECK-LABEL: @fdiv_reassoc_sin_reassoc_cos_strict(
+; CHECK-NEXT: [[TAN:%.*]] = call reassoc double @tan(double [[A:%.*]]) #1
; CHECK-NEXT: ret double [[TAN]]
;
- %1 = call fast double @llvm.sin.f64(double %a)
+ %1 = call reassoc double @llvm.sin.f64(double %a)
%2 = call double @llvm.cos.f64(double %a)
- %div = fdiv fast double %1, %2
+ %div = fdiv reassoc double %1, %2
ret double %div
}
-define double @fdiv_sin_cos_fast_multiple_uses(double %a) {
-; CHECK-LABEL: @fdiv_sin_cos_fast_multiple_uses(
-; CHECK-NEXT: [[TMP1:%.*]] = call fast double @llvm.sin.f64(double [[A:%.*]])
-; CHECK-NEXT: [[TMP2:%.*]] = call fast double @llvm.cos.f64(double [[A]])
-; CHECK-NEXT: [[DIV:%.*]] = fdiv fast double [[TMP1]], [[TMP2]]
+define double @fdiv_sin_cos_reassoc_multiple_uses(double %a) {
+; CHECK-LABEL: @fdiv_sin_cos_reassoc_multiple_uses(
+; CHECK-NEXT: [[TMP1:%.*]] = call reassoc double @llvm.sin.f64(double [[A:%.*]])
+; CHECK-NEXT: [[TMP2:%.*]] = call reassoc double @llvm.cos.f64(double [[A]])
+; CHECK-NEXT: [[DIV:%.*]] = fdiv reassoc double [[TMP1]], [[TMP2]]
; CHECK-NEXT: call void @use(double [[TMP2]])
; CHECK-NEXT: ret double [[DIV]]
;
- %1 = call fast double @llvm.sin.f64(double %a)
- %2 = call fast double @llvm.cos.f64(double %a)
- %div = fdiv fast double %1, %2
+ %1 = call reassoc double @llvm.sin.f64(double %a)
+ %2 = call reassoc double @llvm.cos.f64(double %a)
+ %div = fdiv reassoc double %1, %2
call void @use(double %2)
ret double %div
}
-define double @fdiv_sin_cos_fast(double %a) {
-; CHECK-LABEL: @fdiv_sin_cos_fast(
-; CHECK-NEXT: [[TAN:%.*]] = call fast double @tan(double [[A:%.*]]) #1
+define double @fdiv_sin_cos_reassoc(double %a) {
+; CHECK-LABEL: @fdiv_sin_cos_reassoc(
+; CHECK-NEXT: [[TAN:%.*]] = call reassoc double @tan(double [[A:%.*]]) #1
; CHECK-NEXT: ret double [[TAN]]
;
- %1 = call fast double @llvm.sin.f64(double %a)
- %2 = call fast double @llvm.cos.f64(double %a)
- %div = fdiv fast double %1, %2
+ %1 = call reassoc double @llvm.sin.f64(double %a)
+ %2 = call reassoc double @llvm.cos.f64(double %a)
+ %div = fdiv reassoc double %1, %2
ret double %div
}
-define float @fdiv_sinf_cosf_fast(float %a) {
-; CHECK-LABEL: @fdiv_sinf_cosf_fast(
-; CHECK-NEXT: [[TANF:%.*]] = call fast float @tanf(float [[A:%.*]]) #1
+define float @fdiv_sinf_cosf_reassoc(float %a) {
+; CHECK-LABEL: @fdiv_sinf_cosf_reassoc(
+; CHECK-NEXT: [[TANF:%.*]] = call reassoc float @tanf(float [[A:%.*]]) #1
; CHECK-NEXT: ret float [[TANF]]
;
- %1 = call fast float @llvm.sin.f32(float %a)
- %2 = call fast float @llvm.cos.f32(float %a)
- %div = fdiv fast float %1, %2
+ %1 = call reassoc float @llvm.sin.f32(float %a)
+ %2 = call reassoc float @llvm.cos.f32(float %a)
+ %div = fdiv reassoc float %1, %2
ret float %div
}
-define fp128 @fdiv_sinfp128_cosfp128_fast(fp128 %a) {
-; CHECK-LABEL: @fdiv_sinfp128_cosfp128_fast(
-; CHECK-NEXT: [[TANL:%.*]] = call fast fp128 @tanl(fp128 [[A:%.*]]) #1
+define fp128 @fdiv_sinfp128_cosfp128_reassoc(fp128 %a) {
+; CHECK-LABEL: @fdiv_sinfp128_cosfp128_reassoc(
+; CHECK-NEXT: [[TANL:%.*]] = call reassoc fp128 @tanl(fp128 [[A:%.*]]) #1
; CHECK-NEXT: ret fp128 [[TANL]]
;
- %1 = call fast fp128 @llvm.sin.fp128(fp128 %a)
- %2 = call fast fp128 @llvm.cos.fp128(fp128 %a)
- %div = fdiv fast fp128 %1, %2
+ %1 = call reassoc fp128 @llvm.sin.fp128(fp128 %a)
+ %2 = call reassoc fp128 @llvm.cos.fp128(fp128 %a)
+ %div = fdiv reassoc fp128 %1, %2
ret fp128 %div
}
More information about the llvm-commits
mailing list