[PATCH] D43080: Adding Msan support to FreeBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 22:51:38 PST 2018


devnexen added inline comments.


================
Comment at: lib/msan/msan_interceptors.cc:683
 
-#if SANITIZER_NETBSD
+#if SANITIZER_NETBSD || SANITIZER_FREEBSD
 INTERCEPTOR(int, fstat, int fd, void *buf) {
----------------
krytarowski wrote:
> emaste wrote:
> > We ought to keep a consistent ordering, e.g. there's a `Linux|FreeBSD|NetBSD` already.
> Personally, I prefer alphabetical order.
> 
> > Android FreeBSD Fuchsia Linux Mac NetBSD OpenBSD Solaris...
I agree just because NetBSD was before I added later.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43080





More information about the llvm-commits mailing list