[PATCH] D43278: Add Xray instrumentation support to FreeBSD

Ed Maste via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 18:40:42 PST 2018


emaste added inline comments.


================
Comment at: lib/xray/tests/CMakeLists.txt:32
           -lstdc++ -lm ${CMAKE_THREAD_LIBS_INIT}
-          -lpthread
-          -ldl -lrt)
+          ${CMAKE_DL_LIBS_INIT} -lrt)
       set_target_properties(XRayUnitTests PROPERTIES RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
----------------
so we just had redundant -lpthread before, from both `${CMAKE_THREAD_LIBS_INIT}` and explicit `-lpthread`?


https://reviews.llvm.org/D43278





More information about the llvm-commits mailing list