[PATCH] D43278: Add Xray instrumentation support to FreeBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/xray/xray_fdr_logging_impl.h:203
     NewBuffer.RecordKind = uint8_t(MetadataRecord::RecordKinds::NewBuffer);
-    std::memcpy(&NewBuffer.Data, &Tid, sizeof(pid_t));
+    std::memcpy(&NewBuffer.Data, &Tid, sizeof(int32_t));
   }
----------------
krytarowski wrote:
> Is this Endian safe?
No I did the diff too fast I create a temporary int32_t var normally.


https://reviews.llvm.org/D43278