[PATCH] D43278: Add Xray instrumentation support to FreeBSD

Kamil Rytarowski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 17:10:47 PST 2018


krytarowski added inline comments.


================
Comment at: lib/xray/xray_fdr_logging_impl.h:203
     NewBuffer.RecordKind = uint8_t(MetadataRecord::RecordKinds::NewBuffer);
-    std::memcpy(&NewBuffer.Data, &Tid, sizeof(pid_t));
+    std::memcpy(&NewBuffer.Data, &Tid, sizeof(int32_t));
   }
----------------
Is this Endian safe?


https://reviews.llvm.org/D43278





More information about the llvm-commits mailing list