[PATCH] D43278: Add Xray instrumentation support to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/xray/xray_utils.cc:20
+#if SANITIZER_FREEBSD
+#include <sys/thr.h>
+#endif
----------------
krytarowski wrote:
> I assume that we can drop changes from this file.
> 
> While there, FreeBSD's implementation of GetTid() in sanitizer is `pthread_self()`.
> 
> It looks incorrect to me as it returns a pointer to an internal `struct pthread` type. I would consider switching it to `thr_self(2)`.
The common_sanitizer part can be done with a separate revision.


https://reviews.llvm.org/D43278