[PATCH] D42834: [RISCV] Implement c.lui immedate operand constraint
Ana Pazos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 14 15:11:05 PST 2018
apazos added a comment.
LGTM.
================
Comment at: lib/Target/RISCV/RISCVInstrInfoC.td:52
+// c_lui_imm check the immediate range in [1, 31] or [0xfffe0, 0xfffff].
+// The RISCV ISA describe the constraint as [1, 63] with signed extension
+// highest bit, so eventuall, the upper value could represent will be [1, 31]
----------------
just some typo (checks, describes) and missing end point '.'.
Repository:
rL LLVM
https://reviews.llvm.org/D42834
More information about the llvm-commits
mailing list