[PATCH] D42846: [PartialInlining] Use isInlineViable to detect constructs preventing inlining.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

In https://reviews.llvm.org/D42846#1008060, @efriedma wrote:

> Can you explain the difference between llvm::isInlineViable and CodeExtractor::isBlockValidForExtraction?  I'm kind of confused why they're checking different things.


I think CodeExtractor is not only used to extract code for partial inlining, but also used by LoopExtractor. I suppose this is why they do not check the same thing, but I think it would make sense to check for non-inlinable blocks in CodeExtractor too. Maybe we should add an isInlineableBlock function and use them in isBlockValidForExtraction?


https://reviews.llvm.org/D42846