[PATCH] D42611: [ThinLTO/CFI] Include TYPE_ID summaries into GLOBALVAL_SUMMARY_BLOCK

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 14:25:33 PST 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll:59
+  ; Check that the call was devirtualized.
+  ; CHECK-IR: %call = tail call i32 @_ZN1A1nEi
+  %1 = tail call { i8*, i1 } @llvm.type.checked.load(i8* %vtable5, i32 8, metadata !"_ZTS1A")
----------------
Move this to before line 71.


================
Comment at: clang/test/CodeGen/thinlto-distributed-cfi-devirt.ll:93
+
+define i32 @main(){
+entry:
----------------
I think you can remove this `main` function as well as the one in `thinlto-distributed-cfi.ll`.


https://reviews.llvm.org/D42611





More information about the llvm-commits mailing list