[PATCH] D43278: Add Xray instrumentation support to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/xray/tests/unit/fdr_logging_test.cc:160
     std::thread t{[I, &Threads] {
       fdrLoggingHandleArg0(I + 1, XRayEntryType::ENTRY);
----------------
devnexen wrote:
> krytarowski wrote:
> > Missing context.. but Threads is defined as: `std::array<pid_t, 2> Threads;`
> > 
> > Shouldn't this be `Tid_t` or `uint64_t`?
> Good question ... I d say Tid_t ?
If we can get access to `Tid_t` go for it. It's just a test so `uint64_t` is fine too.


https://reviews.llvm.org/D43278