[PATCH] D43264: [WebAssembly] Add explicit symbol table

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/InputChunks.h:193-194
+  StringRef getComdat() const override { return StringRef(); }
+  uint32_t getOutputIndex() const { return OutputIndex.getValue(); }
+  bool hasOutputIndex() const { return OutputIndex.hasValue(); }
+  void setOutputIndex(uint32_t Index);
----------------
ruiu wrote:
> Looks like this class is defined to wrap WasmGlobal objects so that they have these methods -- {set,get,has}OutputIndex. Is that correct? This class design looks really odd to me.
Yes, that is pretty much exactly what it does.  That is the behavior we need.

Should we move it out of this hierarchy, and called it "OutputGlobal" perhaps?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43264