[PATCH] D43264: [WebAssembly] Add explicit symbol table

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/InputChunks.h:193-194
+  StringRef getComdat() const override { return StringRef(); }
+  uint32_t getOutputIndex() const { return OutputIndex.getValue(); }
+  bool hasOutputIndex() const { return OutputIndex.hasValue(); }
+  void setOutputIndex(uint32_t Index);
----------------
Looks like this class is defined to wrap WasmGlobal objects so that they have these methods -- {set,get,has}OutputIndex. Is that correct? This class design looks really odd to me.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43264