[PATCH] D42403: libcxx: Move #include_next <math.h> out of header guard in wrapper header.

Marshall Clow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 14 12:01:25 PST 2018


mclow.lists added a comment.

A couple of points to consider here:

- "Windows users expect" is not a compelling argument.
- If done, this behavior should be windows-specific.
- You should include <__config> before anything else.



================
Comment at: libcxx/trunk/test/libcxx/depr/depr.c.headers/math_h.sh.cpp:12
+
+#ifdef _MSC_VER
+
----------------
This test should use the libc++ macro, not the naked `_MSC_VER`


Repository:
  rL LLVM

https://reviews.llvm.org/D42403





More information about the llvm-commits mailing list