[PATCH] D43309: GlobalISel: Add templated functions and pattern matcher support for some more opcodes

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added a comment.

Minor nitpick.. Otherwise LGTM..



================
Comment at: unittests/CodeGen/GlobalISel/PatternMatchTest.cpp:317
+  ASSERT_TRUE(
+      mi_match(MIBCast->getOperand(0).getReg(), MRI, m_SpecificType(v2s32)));
 }
----------------
Could you also match the source of the MIBCast in order to be complete?

Otherwise LGTM!!


https://reviews.llvm.org/D43309